Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data #38

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Update data #38

merged 1 commit into from
Jun 24, 2024

Conversation

wongjingping
Copy link
Collaborator

@wongjingping wongjingping commented Jun 24, 2024

We make the following data changes:

  • Add students graduating in < 10 and > 10 years for advising. This is to allow our data to test if the SQL contains a filter for the past 10 years for the following question: How many students were predicted to graduate in the last 10 years?. Currently all of the available data is within the "past 10 years" hence it won't test if the SQL actually filtered correctly for the past 10 years.
  • Add reviews < 10 and > 10 months to allow our data to test if SQL accurately filters past 10 months since today.

Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!

@wongjingping wongjingping merged commit 58139a4 into main Jun 24, 2024
2 checks passed
@wongjingping wongjingping deleted the jp/update1 branch June 24, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants