Fix spurious ambiguous call error (#1057)

Bugs fixed:
- Fix issue where "call is ambiguous" could be reported attempting to call certain methods (closes #1056)

Technical:
- Add an additional kind of test ('project tests') that are built using MSBuild and can reference other projects and packages.

.config/dotnet-tools.json

@@ -15,7 +15,7 @@
       ]
     },
     "ghul.compiler": {
-      "version": "0.7.1",
+      "version": "0.7.2",
       "commands": [
         "ghul-compiler"
       ]

.github/workflows/ci.yml

@@ -101,7 +101,7 @@ jobs:
         name: ghul-compiler-package
         path: ./nupkg/ghul.compiler.${{ needs.version.outputs.package }}.nupkg
 
-  tests:
+  integration_tests:
     needs: [version, bootstrap]
     name: Run tests
 
@@ -143,8 +143,41 @@ jobs:
         name: test-results
         path: test-results.txt
 
+  project_tests:
+    needs: [version, bootstrap]
+    name: Run project tests
+
+    runs-on: ubuntu-latest
+    container:
+      image: mcr.microsoft.com/dotnet/sdk:8.0-jammy
+
+    timeout-minutes: 5
+
+    steps:
+    - uses: actions/checkout@v3
+
+    - name: Download ghul.compiler package
+      uses: actions/download-artifact@v4
+      with:
+        name: ghul-compiler-package
+        path: nupkg
+
+    - name: Install ghul.compiler
+      run: dotnet tool update --local ghul.compiler --version ${{ needs.version.outputs.package }} --add-source nupkg
+
+    - name: Restore local .NET tools
+      run: dotnet tool restore
+
+    - name: Run project tests
+      run: bash -c "set -o pipefail ; dotnet ghul-test --use-dotnet-build project-tests | tee project-test-results.txt"
+
+    - uses: actions/upload-artifact@v4
+      with:
+        name: project-test-results
+        path: project-test-results.txt
+
   publish_beta_package:
-    needs: [version, unit_tests, tests]
+    needs: [version, unit_tests, integration_tests, project_tests]
     name: Publish beta package
 
     timeout-minutes: 5
@@ -286,7 +319,7 @@ jobs:
       run: docker push degory/ghul-devcontainer:dotnet
 
   publish_release_package:
-    needs: [version, unit_tests, container_tests]
+    needs: [version, unit_tests, project_tests, container_tests]
     name: Publish release package
 
     timeout-minutes: 5

.vscode/tasks.json

@@ -81,6 +81,7 @@
             "dependsOn": [
                 "Pack"
             ],
+            "group": "build",
             "presentation": {
                 "reveal": "silent",
                 "revealProblems": "onProblem",

Directory.Build.props

@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <Version>0.6.21-alpha.1</Version>
+    <Version>0.7.3-alpha.51</Version>
     <NoWarn>$(NoWarn);NU1507</NoWarn>
   </PropertyGroup>
 

integration-tests/create.sh

@@ -6,7 +6,7 @@ if [ -z "${ROOT}" ] ; then
     ROOT=`pwd`
 fi
 
-echo root is ${ROOT}
+echo will create test under "${ROOT}/integration-tests"
 
 read -p "new test name (folder/kebab-case-test-name): " TEST_NAME
 

project-tests/ambiguous-method-hiding-1/.vscode/ghul.json

@@ -0,0 +1,6 @@
+{
+    "compiler": "dotnet ../../../publish/ghul.dll",
+    "source": [
+        "."
+    ]
+}

project-tests/ambiguous-method-hiding-1/.vscode/tasks.json

@@ -0,0 +1,23 @@
+{
+    "version": "2.0.0",
+    "tasks": [
+        {
+            "label": "Run test",
+            "command": "dotnet ghul-test --use-dotnet-build \"${workspaceFolder}\"",
+            "type": "shell",
+            "group": {
+                "kind": "test",
+                "isDefault": true
+            }
+        },
+        {
+            "label": "Capture test expectation",
+            "command": "../../tasks/capture.sh \"${workspaceFolder}\"",
+            "type": "shell",
+            "group": {
+                "kind": "build",
+                "isDefault": true
+            }
+        }
+    ]
+}

project-tests/ambiguous-method-hiding-1/ambiguous-method-hiding.ghulproj

@@ -0,0 +1,14 @@
+<Project Sdk="Microsoft.NET.Sdk">
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net8.0</TargetFramework>
+    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+    <GhulCompiler>dotnet ghul-compiler</GhulCompiler>
+    <AssemblyName>binary</AssemblyName>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <GhulSources Include="**/*.ghul" />
+    <ProjectReference Include="../cs-test-assembly/cs-test-assembly.csproj" />
+  </ItemGroup>
+</Project>

project-tests/ambiguous-method-hiding-1/run.expected

@@ -0,0 +1,32 @@
+will call Base().method()...
+---- Base.Method()
+Base: from Base.Method()
+
+will call Derived().method()...
+>>>> OverrideSameReturnType.Method()
+---- Base.Method()
+<<<< OverrideSameReturnType.Method()
+OverrideSameReturnType: from Base.Method() via OverrideSameReturnType.Method()
+
+will call NewSameReturnType().method()...
+---- NewSameReturnType.Method()
+NewSameReturnType: from NewSameReturnType.Method()
+
+will call NewVirtualSameReturnType().method()...
+---- NewVirtualSameReturnType.Method()
+NewVirtualSameReturnType: from NewVirtualSameReturnType.Method()
+
+will call OverrideCovariantReturnType().method()...
+>>>> OverrideCovariantReturnType.Method()
+---- Base.Method()
+<<<< OverrideCovariantReturnType.Method()
+OverrideCovariantReturnType: from Base.Method() via OverrideCovariantReturnType.Method()
+
+will call NewCovariantReturnType().method()...
+---- NewCovariantReturnType.Method()
+NewCovariantReturnType: from NewCovariantReturnType.Method()
+
+will call NewVirtualCovariantReturnType().method()...
+---- NewVirtualCovariantReturnType.Method()
+NewVirtualCovariantReturnType: from NewVirtualCovariantReturnType.Method()
+

project-tests/ambiguous-method-hiding-1/test.ghul

@@ -0,0 +1,37 @@
+namespace Test is
+    use IO.Std.write_line;
+
+    use MethodHidingAndOverriding;
+
+    class Main is
+        entry() static is
+            write_line("will call Base().method()...");
+            write_line("Base: " + new Base().method());
+            write_line();
+
+            write_line("will call Derived().method()...");
+            write_line("OverrideSameReturnType: " + new OverrideSameReturnType().method());
+            write_line();
+
+            write_line("will call NewSameReturnType().method()...");
+            write_line("NewSameReturnType: " + new NewSameReturnType().method());
+            write_line();
+
+            write_line("will call NewVirtualSameReturnType().method()...");
+            write_line("NewVirtualSameReturnType: " + new NewVirtualSameReturnType().method());
+            write_line();
+
+            write_line("will call OverrideCovariantReturnType().method()...");
+            write_line("OverrideCovariantReturnType: " + new OverrideCovariantReturnType().method());
+            write_line();
+
+            write_line("will call NewCovariantReturnType().method()...");
+            write_line("NewCovariantReturnType: " + new NewCovariantReturnType().method());
+            write_line();
+
+            write_line("will call NewVirtualCovariantReturnType().method()...");
+            write_line("NewVirtualCovariantReturnType: " + new NewVirtualCovariantReturnType().method());
+            write_line();
+        si
+    si
+si

project-tests/cs-test-assembly/.gitignore

@@ -0,0 +1,2 @@
+**/*.sln
+nupkg/

project-tests/cs-test-assembly/cs-test-assembly.cs

@@ -0,0 +1,65 @@
+namespace MethodHidingAndOverriding {
+    public class Base {
+        public virtual object? Method() {
+            System.Console.WriteLine("---- Base.Method()");
+            return "from Base.Method()";
+        }
+    }
+
+    public class OverrideSameReturnType: Base {
+        public override object? Method()
+        {            
+            System.Console.WriteLine(">>>> OverrideSameReturnType.Method()");
+            var result = base.Method() + " via OverrideSameReturnType.Method()";
+            System.Console.WriteLine("<<<< OverrideSameReturnType.Method()");
+
+            return result;
+        }
+    }
+
+    public class NewSameReturnType: Base {
+        public new object? Method() {
+            System.Console.WriteLine("---- NewSameReturnType.Method()");
+
+            return "from NewSameReturnType.Method()";
+        }
+    }
+
+    public class NewVirtualSameReturnType: Base {
+        public virtual new object? Method() {
+            System.Console.WriteLine("---- NewVirtualSameReturnType.Method()");
+
+            return "from NewVirtualSameReturnType.Method()";
+        }
+    }
+
+    public class OverrideCovariantReturnType: Base {
+        public override string? Method()
+        {
+            System.Console.WriteLine(">>>> OverrideCovariantReturnType.Method()");
+            var result = base.Method() + " via OverrideCovariantReturnType.Method()";
+            System.Console.WriteLine("<<<< OverrideCovariantReturnType.Method()");
+
+            return result;
+        }
+    }
+
+    public class NewCovariantReturnType: Base {
+        public new string? Method() {
+            System.Console.WriteLine("---- NewCovariantReturnType.Method()");
+
+            return "from NewCovariantReturnType.Method()";
+        }
+    }
+
+    public class NewVirtualCovariantReturnType: Base {
+        public virtual new string? Method() {
+            System.Console.WriteLine("---- NewVirtualCovariantReturnType.Method()");
+
+            return "from NewVirtualCovariantReturnType.Method()";
+        }
+    }
+}
+
+
+

project-tests/cs-test-assembly/cs-test-assembly.csproj

@@ -0,0 +1,14 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net8.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <!-- <Version>1.0.4</Version> -->
+    <PackageOutputPath>./nupkg</PackageOutputPath>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Remove="ghul.runtime" />
+  </ItemGroup>
+</Project>

src/ioc/container.ghul

@@ -387,7 +387,7 @@ namespace IoC is
 
             type_mapper = new Semantic.DotNet.TYPE_MAPPER(dotnet_symbol_table, innate_symbol_lookup, type_name_map, assemblies);
 
-            symbol_factory = new Semantic.DotNet.SYMBOL_FACTORY(namespaces, type_name_map, type_mapper, referenced_assemblies, assemblies);
+            symbol_factory = new Semantic.DotNet.SYMBOL_FACTORY(namespaces, type_name_map, type_mapper, referenced_assemblies, assemblies, logger);
 
             assembly_info = new Semantic.DotNet.ASSEMBLY_INFO(ir_context);