Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming overridden symbols does not work reliably #923

Closed
degory opened this issue Jan 3, 2022 · 1 comment · Fixed by #926
Closed

Renaming overridden symbols does not work reliably #923

degory opened this issue Jan 3, 2022 · 1 comment · Fixed by #926
Labels
bug

Comments

@degory
Copy link
Owner

degory commented Jan 3, 2022 •
edited
Loading

Renaming overridden symbols correctly renames references including in derived types, but it does not always rename all overriding definitions.
@degory degory added the bug label Jan 3, 2022
@degory
Copy link
Owner Author

degory commented Jan 3, 2022

Think the scenario that triggers this is if a symbol is overridden but not otherwise referenced.

degory added a commit that referenced this issue Jan 4, 2022
@degory
Fix issues with symbol renaming via the VSCE
c45c3cc 
Bugs fixed:
- Renaming overridden symbols does not work reliably (closes #923)
- Renaming overridden symbols in generic types is not reliable (closes #924)

Enhancements:
- Include the definition of methods and properties in results of go-to implementation
@degory degory mentioned this issue Jan 4, 2022
Merged
degory added a commit that referenced this issue Jan 4, 2022
@degory
Fix issues when renaming symbols via the VSCE (#926)
583c533 
Bugs fixed:
- Renaming overridden symbols does not work reliably (closes #923)
- Renaming overridden symbols in generic types is not reliable (closes #924)

Enhancements:
- Include the definition of methods and properties in results of go-to implementation
Repository owner moved this from Todo to Done in ghūl programming language - stable release Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
ghūl programming language - stable release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues when renaming symbols via the VSCE degory/ghul
1 participant
@degory