Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onStop called multiple times #289

Closed
dehora opened this issue Oct 9, 2017 · 0 comments
Closed

onStop called multiple times #289

dehora opened this issue Oct 9, 2017 · 0 comments

Comments

@dehora
Copy link
Owner

dehora commented Oct 9, 2017

StreamProcessor.onStop is called multiple times (eg after each retry attempt) as part of the underlying RxJava onCancel cycle. It's probably less confusing to end users if it's called just once as part of the StreamProcessor stop cycle.
dehora added a commit that referenced this issue Oct 9, 2017
@dehora
Calls StreamObserver.onStop only on termination.
7445c5f 
This calls onStop once, when the processor is being stopped. It also
calls onCompleted after the stop cycle is complete. Previously onStop
was being called multiple times, for example on every retry.

For #289.
dehora added a commit that referenced this issue Oct 9, 2017
@dehora
Calls StreamObserver.onStop only on termination.
51e03e1 
This calls onStop once, when the processor is being stopped. It also
documents onCompleted as being called after a processor has finished
due to being configure ot fetch only a subset. Previously onStop
was being called multiple times, for example on every retry.

For #289.
@dehora dehora mentioned this issue Oct 9, 2017
Merged
dehora added a commit that referenced this issue Oct 9, 2017
@dehora
Calls StreamObserver.onStop only on termination.
d446e00 
This calls onStop once, when the processor is being stopped. It also
documents onCompleted as being called after a processor has finished
due to being configure ot fetch only a subset. Previously onStop
was being called multiple times, for example on every retry.

For #289.
dehora added a commit that referenced this issue Oct 9, 2017
@dehora
Calls StreamObserver.onStop only on termination.
bf74da1 
This calls onStop once, when the processor is being stopped. It also
documents onCompleted as being called after a processor has finished
due to being configure ot fetch only a subset. Previously onStop
was being called multiple times, for example on every retry.

For #289.
dehora added a commit that referenced this issue Oct 9, 2017
@dehora
Calls StreamObserver.onStop only on termination.
4e35637 
This calls onStop once, when the processor is being stopped. It also
documents onCompleted as being called after a processor has finished
due to being configure ot fetch only a subset. Previously onStop
was being called multiple times, for example on every retry.

For #289.
@dehora dehora closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dehora