Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs python linting #8

Closed
mboersma opened this issue Feb 3, 2016 · 3 comments
Closed

Needs python linting #8

mboersma opened this issue Feb 3, 2016 · 3 comments
Assignees
@ultimateboy
Labels
easy fix needs tests
Milestone
v2.5

Comments

@mboersma
Copy link
Member

mboersma commented Feb 3, 2016

Since #6 introduces some python code, we should flake8 source files in CI as we do in deis/workflow.
@bacongobbler
Copy link
Member

related to #87

@bacongobbler
Copy link
Member

also related to #36

@helgi helgi added the easy fix label Sep 1, 2016
@helgi
Copy link
Contributor

helgi commented Sep 1, 2016

See deis/controller and how we do dev_requirements.txt, how the Makefile looks like for that (make test and co) and how that interacts in Travis and friends

@ultimateboy ultimateboy mentioned this issue Sep 1, 2016
Merged
@helgi helgi added this to the v2.5 milestone Sep 2, 2016
ultimateboy added a commit that referenced this issue Sep 2, 2016
@ultimateboy
feat(tests) Add flake8 linting for python code (#91)
4273b5c 
Fixes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ultimateboy ultimateboy

Labels
easy fix needs tests
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
5 participants
@helgi @mboersma @ultimateboy @bacongobbler @deis-admin