Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grafana,telegraf): make curl fail on unsuccessful HTTP codes #157

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

mboersma
Copy link
Member

@mboersma mboersma commented Oct 25, 2016

Adds the -f flag to curl downloads to avoid the possibility of creating a file with contents like:

$ cat /usr/bin/telegraf 
<?xml version='1.0' encoding='UTF-8'?><Error><Code>AccessDenied</Code><Message>Access denied.</Message><Details>Anonymous users does not have storage.objects.get access to object telegraf/telegraf.</Details></Error>

See #156. Thanks to @felixbuenemann for suggesting the fix!

@mboersma mboersma added this to the v2.8 milestone Oct 25, 2016
@mboersma mboersma self-assigned this Oct 25, 2016
@deis-bot
Copy link

@jchauncey, @helgi and @krancour are potential reviewers of this pull request based on my analysis of git blame information. Thanks @mboersma!

@mboersma mboersma merged commit 8326179 into deis:master Oct 25, 2016
@mboersma mboersma deleted the make-curl-fail branch October 25, 2016 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants