cluster_id is vulnerable to race condition when called concurrently #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arschles and @kmala are potential reviewers of this pull request based on my analysis of |
Current coverage is 43.47% (diff: 0.00%)@@ master #94 diff @@
==========================================
Files 11 11
Lines 578 582 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 250 253 +3
- Misses 284 285 +1
Partials 44 44
|
1) add generic data.ClusterID type in sendVersions type struct 2) enable common clusterID reference to be included in multiple, concurrent jobs, so that appropriate locking can be enforced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Get()method is in fact an "insert if not exist"-style retriever, so it should be protected with a RW lock.fixes #93