Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Sampling Design Suggestions #18

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Random Sampling Design Suggestions #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 37 additions & 25 deletions x-pack/plugins/lens/public/datasources/form_based/layer_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ import {
EuiRange,
EuiFlexGroup,
EuiFlexItem,
EuiBadge,
EuiBetaBadge,
EuiText,
EuiLink,
EuiSpacer,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { css } from '@emotion/react';
import React from 'react';
import { FormattedMessage } from '@kbn/i18n-react';
import type { DatasourceLayerSettingsProps } from '../../types';
Expand All @@ -35,41 +37,51 @@ export function LayerSettingsPanel({
data-test-subj="lns-indexPattern-random-sampling-row"
fullWidth
helpText={
<FormattedMessage
id="xpack.lens.xyChart.randomSampling.help"
defaultMessage="The sampling is accomplished by providing a random subset of the entire set of documents. The lower the value the higher the error and speed: consider the usage of lower values for big datasets. {link}"
values={{
link: (
<EuiLink
href="https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations-random-sampler-aggregation.html"
target="_blank"
external
>
<FormattedMessage
id="xpack.lens.xyChart.randomSampling.learnMore"
defaultMessage="Learn more"
/>
</EuiLink>
),
}}
/>
<>
<EuiSpacer size="s" />
<p>
<FormattedMessage
id="xpack.lens.xyChart.randomSampling.help"
defaultMessage="Lower sampling percentages increase speed at the cost of accuracy. It is recommended that lower sampling percentages only be used for large datasets. {link}"
values={{
link: (
<EuiLink
href="https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations-random-sampler-aggregation.html"
target="_blank"
external
>
<FormattedMessage
id="xpack.lens.xyChart.randomSampling.learnMore"
defaultMessage="View documentation"
/>
</EuiLink>
),
}}
/>
</p>
</>
}
label={
<>
{i18n.translate('xpack.lens.xyChart.randomSampling.label', {
defaultMessage: 'Random sampling',
})}{' '}
<EuiBadge color="hollow">
{i18n.translate('xpack.lens.randomSampling.experimentalLabel', {
<EuiBetaBadge
css={css`
vertical-align: middle;
`}
iconType="beaker"
label={i18n.translate('xpack.lens.randomSampling.experimentalLabel', {
defaultMessage: 'Technical preview',
})}
</EuiBadge>
size="s"
/>
</>
}
>
<EuiFlexGroup>
<EuiFlexGroup gutterSize="none">
<EuiFlexItem grow={false}>
<EuiText size="s">
<EuiText color="subdued" size="xs">
<FormattedMessage
id="xpack.lens.xyChart.randomSampling.speedLabel"
defaultMessage="Speed"
Expand Down Expand Up @@ -102,7 +114,7 @@ export function LayerSettingsPanel({
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiText size="s">
<EuiText color="subdued" size="xs">
<FormattedMessage
id="xpack.lens.xyChart.randomSampling.accuracyLabel"
defaultMessage="Accuracy"
Expand Down