Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cert Manager: Fix extension to get config from annotations #1159

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Cert Manager: Fix extension to get config from annotations #1159

merged 1 commit into from
Feb 28, 2023

Conversation

Sgitario
Copy link
Collaborator

Fix #1158

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

aureamunoz
aureamunoz approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM Thank you

@Sgitario Sgitario merged commit 2aea503 into dekorateio:main Feb 28, 2023
@Sgitario Sgitario deleted the 1158 branch February 28, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aureamunoz aureamunoz aureamunoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certmanager annotation config fails missing name
2 participants
@Sgitario @aureamunoz