Skip to content

Commit

Permalink
Add treeshake to some core, ml and shared-ux modules (elastic#182348)
Browse files Browse the repository at this point in the history 
## Summary

While debugging another issue I've noticed there were few packages
without treeshake enabled who could be optimized for bundle size, so
I've enabled it for a few of them.
This PR focuses only on `shared-ux`, `core` and `ml` packages for now.

it relies on the tests to check if the treeshake broke anything deep.
  • Loading branch information
@dej611
dej611 authored May 3, 2024
1 parent 0291c81 commit a6491ab
Show file tree
Hide file tree
Showing 50 changed files with 100 additions and 50 deletions.
3 changes: 2 additions & 1 deletion packages/core/notifications/core-notifications-browser-internal/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"private": true,
"version": "1.0.0",
"author": "Kibana Core",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/core/notifications/core-notifications-browser/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"private": true,
"version": "1.0.0",
"author": "Kibana Core",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/avatar/solution/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-avatar-solution",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/button/exit_full_screen/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-button-exit-full-screen",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/button_toolbar/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-button-toolbar",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/card/no_data/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-card-no-data",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/chrome/navigation/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-chrome-navigation",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/code_editor/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/code-editor",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/error_boundary/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-error-boundary",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/file/context/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-file-context",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/file/file_picker/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-file-picker",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/file/file_upload/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-file-upload",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/file/image/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-file-image",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/file/util/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-file-util",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/link/redirect_app/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-link-redirect-app",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/markdown/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-markdown",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/modal/tabbed/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-tabbed-modal",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/page/analytics_no_data/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-page-analytics-no-data",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/page/kibana_no_data/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-page-kibana-no-data",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/page/kibana_template/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-page-kibana-template",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/page/no_data/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-page-no-data",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/page/no_data_config/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-page-no-data-config",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/page/solution_nav/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-page-solution-nav",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/prompt/no_data_views/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-prompt-no-data-views",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/prompt/not_found/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-prompt-not-found",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/shared-ux/router/impl/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/shared-ux-router",
"private": true,
"version": "1.0.0",
"license": "SSPL-1.0 OR Elastic License 2.0"
"license": "SSPL-1.0 OR Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/agg_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"homepage": "https://docs.elastic.dev/kibana-dev-docs/api/kbn-ml-agg-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/aiops_change_point_detection/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/aiops-change-point-detection",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/aiops_common/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"homepage": "https://docs.elastic.dev/kibana-dev-docs/api/kbn-aiops-common",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/aiops_log_pattern_analysis/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/aiops-log-pattern-analysis",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/aiops_log_rate_analysis/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/aiops-log-rate-analysis",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/cancellable_search/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"author": "Machine Learning UI",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/category_validator/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-category-validator",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/data_view_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-data-view-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/error_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-error-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/inference_integration_flyout/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/inference_integration_flyout",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/is_defined/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-is-defined",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/is_populated_object/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"homepage": "https://docs.elastic.dev/kibana-dev-docs/api/kbn-ml-is-populated-object",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/nested_property/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"homepage": "https://docs.elastic.dev/kibana-dev-docs/api/kbn-ml-nested-property",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/number_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-number-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/query_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-query-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/random_sampler_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-random-sampler-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/response_stream/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-response-stream",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/route_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-route-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/runtime_field_utils/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"name": "@kbn/ml-runtime-field-utils",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
3 changes: 2 additions & 1 deletion x-pack/packages/ml/string_hash/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
"homepage": "https://docs.elastic.dev/kibana-dev-docs/api/kbn-ml-string-hash",
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0"
"license": "Elastic License 2.0",
"sideEffects": false
}
Loading

0 comments on commit a6491ab

Please sign in to comment.