Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dialog has a scroll bar now. #3

Merged
merged 1 commit into from
Mar 5, 2017
Merged

Cleanup dialog has a scroll bar now. #3

merged 1 commit into from
Mar 5, 2017

Conversation

TRvanRossum
Copy link

Revolves around this issue. Awaiting feedback.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@RolfStarre
Copy link

The code looks fine to me 👍

I'm assuming you manually tested the changed features?

@TRvanRossum
Copy link
Author

Changed features were manually tested, yes. Also just built the project using ./gradlew build, and no extra tests failed or were skipped due to the change.

@RolfStarre
Copy link

Cool 👍

@TRvanRossum TRvanRossum merged commit c8b2472 into review-issue-2501-fix Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolfStarre RolfStarre RolfStarre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TRvanRossum @RolfStarre