Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects are no longer instantiating during the find and replace procedure #103

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

philwp
Copy link
Contributor

@philwp philwp commented Jan 5, 2024

This PR prevents objects from being instantiated when they are unserialized to perform the find and replace procedure. This is done by setting the allowed_classes filter of unserialize to false

Also, in order to support version of PHP prior to 7.0, a polyfill was added to allow the usage of the allowed_classes filter.

@philwp philwp requested a review from AhmedTheGeek January 5, 2024 13:14
@philwp philwp changed the base branch from master to develop January 12, 2024 17:02
@philwp philwp changed the title WP_HTML_Token objects are now skipped for replacing Objects are no longer instantiating during the find and replace procedure Jan 12, 2024
Copy link
Contributor

@AhmedTheGeek AhmedTheGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philwp philwp merged commit c8d1694 into develop Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants