Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable action for go version updates #88

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Sep 27, 2024

Description

  • PR adds a reusable workflow Update Go Version Workflow that will update the go version in Go based repositories. In order to sign commits, I've created a GitHub App called CSM Release and the token is generated using that App. This will sign commits as release-actions-token[bot]. See: https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#commit-signing
  • It adds another workflow Go Version Update that calls the reusable workflow. The workflow can be manually triggered or it can be triggered across multiple repositories at once using the Trigger Go Version Workflow workflow.
  • It adds a Trigger Go Version Workflow workflow that will run this workflow across the repositories specified.

Screenshot 2024-09-27 154430

Issues

List the issues impacted by this PR:

Issue ID
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

donatwork
donatwork previously approved these changes Sep 30, 2024
Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

.github/workflows/go-version-workflow.yaml Outdated Show resolved Hide resolved
alikdell
alikdell previously approved these changes Sep 30, 2024
Copy link
Collaborator

@eric-young eric-young left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions

.github/workflows/trigger-go-workflow.yaml Show resolved Hide resolved
.github/workflows/go-version-workflow.yaml Outdated Show resolved Hide resolved
Comment on lines +113 to +116
on:
workflow_dispatch:
repository_dispatch:
types: [go-update-workflow]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will trigger this workflow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaynafinocchiaro shaynafinocchiaro merged commit dd787e4 into main Oct 1, 2024
2 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the go-version-workflow branch October 1, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants