[ISSUE-1051] Handle Kubelet's Wrong CSI Call Inconsistent with Real Volume Status for OBS Release 1.3 #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ISSUE-1040] fix pip3 install PyYAML failed. (#1041) Signed-off-by: yimingwangdell <121928908+yimingwangdell@users.noreply.github.com> * [ISSUE-1018] Refine Storage Group Feature (#1031) * add StorageGroupStatus Signed-off-by: Shi, Crane <crane.shi@emc.com> * support StorageGroupStatus in current workflows Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine log Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine error handling Signed-off-by: Shi, Crane <crane.shi@emc.com> * trigger storage group resync if applicable in drive removal Signed-off-by: Shi, Crane <crane.shi@emc.com> * A drive whose Usage is REMOVED will not be selected in any storage group and its existing sg label takes no effect Signed-off-by: Shi, Crane <crane.shi@emc.com> * sg feature will not apply to drive physically removed Signed-off-by: Shi, Crane <crane.shi@emc.com> * handle the drive removal case of drive with manual sg label Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix go lint error Signed-off-by: Shi, Crane <crane.shi@emc.com> * add UT case for drive-removal-triggered sg sync Signed-off-by: Shi, Crane <crane.shi@emc.com> * improve UT coverage Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine sg annotation for drive removal Signed-off-by: Shi, Crane <crane.shi@emc.com> * handle case of invalid sg for drive removal Signed-off-by: Shi, Crane <crane.shi@emc.com> * also exclude removing sg for trigger sg resync in drive removal Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine sg removal status handling Signed-off-by: Shi, Crane <crane.shi@emc.com> * Revert "refine error handling" This reverts commit 06607e7. Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine log and some code logic Signed-off-by: Shi, Crane <crane.shi@emc.com> * try to add immutability validation rule to storagegroup spec Signed-off-by: Shi, Crane <crane.shi@emc.com> * upgrade controller-gen version to v0.9.2 Signed-off-by: Shi, Crane <crane.shi@emc.com> * add storagegroupcontroller UT initial Signed-off-by: Shi, Crane <crane.shi@emc.com> * Revert "add storagegroupcontroller UT initial" This reverts commit 1ea8660. Signed-off-by: Shi, Crane <crane.shi@emc.com> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix Signed-off-by: Shi, Crane <crane.shi@emc.com> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * refactor and add UT of storagegroupcontroller Signed-off-by: Shi, Crane <crane.shi@emc.com> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix storagegroupcontroller UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine the logic of sg deletion Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix bug Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix go-lint err Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix go-lint error Signed-off-by: Shi, Crane <crane.shi@emc.com> * add drive IsClean support, decrease k8s api call, remove manual sg labeling support Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine corner case handling Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine and add UT to storagegroupcontroller Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine storagegroupcontroller and add UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * make controller svc's k8scache also sync sg and lvg objs' Signed-off-by: Shi, Crane <crane.shi@emc.com> * use k8s cache, re-support sg label manual change and refine in sg ctrl Signed-off-by: Shi, Crane <crane.shi@emc.com> * fix lint err Signed-off-by: Shi, Crane <crane.shi@emc.com> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * add storagegroupcontroller UT Signed-off-by: Shi, Crane <crane.shi@emc.com> * storagegroup controller will not reconcile on drive delete event Signed-off-by: Shi, Crane <crane.shi@emc.com> * not support Health, Status, Usage and IsClean as DriveSelector's MatchFields Signed-off-by: Shi, Crane <crane.shi@emc.com> * in storagegroupcontroller's reconcile, only sync drive when reqName is uuid Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine the logic to avoid nil pointer error Signed-off-by: Shi, Crane <crane.shi@emc.com> * revert the usage of k8scache Signed-off-by: Shi, Crane <crane.shi@emc.com> * add custom storage group proposal draft Signed-off-by: Shi, Crane <crane.shi@emc.com> * refine custom storage group proposal Signed-off-by: Shi, Crane <crane.shi@emc.com> --------- Signed-off-by: CraneShiEMC <64512450+CraneShiEMC@users.noreply.github.com> --------- Signed-off-by: yimingwangdell <121928908+yimingwangdell@users.noreply.github.com> Signed-off-by: CraneShiEMC <64512450+CraneShiEMC@users.noreply.github.com> Co-authored-by: yimingwangdell <121928908+yimingwangdell@users.noreply.github.com>
…BS Release 1.3 (#1048) * fix pr validation startup failure * directly use generated file for fake attach block mode * still use loopback device wrap * refine code for creating fake device * fix go lint error * add mock func implementation * fix go lint * fix UT * refine func * support fake attach block mode with fake device, add removeLoopDevice, * fix go lint * refine * support clean fake device in fake-attach block-mode * support non-existing current fake device case * change fake device dir on host * refine log * support the case of get fake device info failure * clean fake device also in removal of fake-attach block-mode vol * if fake-device ann is invalid, re-create the fake device and update ann * fix * enhance * refine * refine * add comment * add UT * add UT * add UT * add UT * check loop device err shouldn't block subsequent op; clean fake device should also check loop device first * update fake-attach doc accordingly * fix typo * refine doc --------- Signed-off-by: CraneShiEMC <64512450+CraneShiEMC@users.noreply.github.com>
…ed volume Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
…e failed volume status Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
…emetal into bugfix-handle-kubelet-wrong-call-obs-1.3 Signed-off-by: Shi, Crane <crane.shi@emc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1051
PR checklist
Testing
Provide test details