Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Capacity Tracking Changes for csi-powerflex #235

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Conversation

VamsiSiddu-7
Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 commented Aug 14, 2023

Description

This pr adds the changes in the GetCapacity Rpc call to support the Storage Capacity tracking for csi-powerflex

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#876

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • I have tested the following scenarios
    1. Installed the csi-powerflex driver enabling the storage capacity in the values.yaml.
    observations:
    the driver installation is successful
    the storage capacity objects are created with the available capacity
    2. Run volume helm test for both thick and thin provisioning
    I am able to verify the GetCapacity call is showing correct available capacity

ashleyvjoy
ashleyvjoy previously approved these changes Aug 14, 2023
KshitijaKakde
KshitijaKakde previously approved these changes Aug 14, 2023
@VamsiSiddu-7 VamsiSiddu-7 dismissed stale reviews from KshitijaKakde and ashleyvjoy via 207ea1e August 14, 2023 09:25
@VamsiSiddu-7 VamsiSiddu-7 merged commit c5d292e into main Aug 14, 2023
@anandrajak1 anandrajak1 deleted the sct-changes branch October 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants