NFS integration test failure fixed #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijaKakde
requested review from
abhi16394,
bharathsreekanth,
JacobGros,
mjsdell,
jooseppi-luna,
ashleyvjoy,
Deepak-Ghivari,
khareRajshree,
Prabhu-Dell,
VamsiSiddu-7,
mbasha-dell and
kumarkgosa
as code owners
VamsiSiddu-7
approved these changes
Sep 4, 2023
| @@ -15,8 +15,7 @@ | |||
| export X_CSI_VXFLEXOS_THICKPROVISION=false | |||
| export X_CSI_VXFLEXOS_ENABLESNAPSHOTCGDELETE="true" | |||
| export X_CSI_VXFLEXOS_ENABLELISTVOLUMESNAPSHOTS="true" | |||
| #Uncomment X_CSI_QUOTA_ENABLED if you want to enable quota for nfs volume | |||
| #export X_CSI_QUOTA_ENABLED="true" | |||
| export X_CSI_QUOTA_ENABLED="true" | |||
There was a problem hiding this comment.
Why are we removing the comment here for X_CSI_QUOTA_ENABLED usage?
There was a problem hiding this comment.
Quota will be set to true by default , so we don't need to comment it
| @@ -522,6 +522,92 @@ Feature: VxFlex OS CSI interface | |||
| And when I call DeleteVolume | |||
| And when I call DeleteVolume | |||
| Then there are no errors | |||
|
|
|||
There was a problem hiding this comment.
why are we changing the sequence of testcases here?
There was a problem hiding this comment.
I have observed , due to multiple tree quota error scenario , the below test scenario were failing for NFS , changing the sequence of test case is avoiding the failure
There was a problem hiding this comment.
In the testcases where the tree quota failure is occurring, then are the volumes created getting rolled back? or is there a manual cleanup required?
khareRajshree
approved these changes
Sep 4, 2023
ashleyvjoy
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NFS integration test failure fixed
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Integration test ran without failure
integration test results.txt