Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the nfsAcls Reference from csi-powerflex. #248

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

VamsiSiddu-7
Copy link
Contributor

Description

This pr removes the nfsAcls Reference from csi-powerflex.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the csi-powerflex driver and the installation is successful.
   driver:
   Container ID:  containerd://3b4c276e15e6247807c48a613fe6b662a504ad950138685fe108ed31bfe356df
   Image:         xxxxxxxxxx/csi-vxflexos:remove-nfsAcls
   Image ID:      xxxx/csi-vxflexos@sha256:7facbaeabd345003cb167185e510dc8cf5aa1b8361c91f645a97e3a7a1736ba3
   Port:          <none>
   Host Port:     <none>
   Command:
     /csi-vxflexos.sh
   Args:
     --leader-election
     --array-config=/vxflexos-config/config
     --driver-config-params=/vxflexos-config-params/driver-config-params.yaml
   State:          Running
     Started:      Tue, 05 Sep 2023 03:08:28 -0400
   Ready:          True
   Restart Count:  0
   Environment:
     CSI_ENDPOINT:                             /var/run/csi/csi.sock
     X_CSI_MODE:                               controller
     X_CSI_VXFLEXOS_ENABLESNAPSHOTCGDELETE:    false
     X_CSI_VXFLEXOS_ENABLELISTVOLUMESNAPSHOT:  false
     SSL_CERT_DIR:                             /certs
   Mounts:
     /var/run/csi from socket-dir (rw)
     /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-hcf52 (ro)
     /vxflexos-config from vxflexos-config (rw)
     /vxflexos-config-params from vxflexos-config-params (rw)
  • Ran cert-csi and it passed with 100%
[2023-09-05 03:12:04]  INFO Avg time of a run:   83.65s
[2023-09-05 03:12:04]  INFO Avg time of a del:   12.02s
[2023-09-05 03:12:04]  INFO Avg time of all:     106.48s
[2023-09-05 03:12:04]  INFO During this run 100.0% of suites succeeded

@VamsiSiddu-7 VamsiSiddu-7 merged commit 621887e into main Sep 5, 2023
@anandrajak1 anandrajak1 deleted the remove-nfsAcls branch October 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants