-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multi-Availability Zone Support #383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add availability zone secret and struct
* Add create volume processing for multi-az * Adjust multi-az secret processing * Rework secret processing * Iterate through all topologies for a zone * Test signing commit * Cleanup secret retrieval and backwards compatibility of storage classes * adapt to use new secret struct * Add multi-az unit tests * Fix golangci-lint issue * Cleanup code logs * Make zone take precendence during NodeGetInfo * Update unit tests credentials --------- Co-authored-by: Lau, Luke <luke.lau1@dell.com>
* Adding Unit tests * fixing formatting issues
* Add zone volume creation integration tests * Fix golangci-lint issue * Create e2e zone tests * Adjust indentation of template yaml files * Adjust indentation of template yaml files * Update e2e file names * Format e2e files for golangci-lint * Update e2e test scenarios * Update pod templates * Address PR comments * Add README to e2e tests * Update sts templates
* Add snapshot check and topology add during zone volume creation * Add topology checks for clones * Add zone snapshot and restore e2e test * Address failed PR checks * Update README * Added e2e tests for clones * Add snap and clone test (#371) * Address PR comments --------- Co-authored-by: Trevor Dawe <trevor.dawe@dell.com> Co-authored-by: Bharath Sreekanth <93715158+bharathsreekanth@users.noreply.github.com>
…is scheduled (#378) * configure driver node service to only ping arrays in the same zone as the service. Co-authored-by: Fernando Alfaro Campos <Fernando.Alfaro_campos@Dell.com> Co-authored-by: Trevor Dawe <trevor.dawe@dell.com>
falfaroc
requested review from
abhi16394,
adarsh-dell,
AkshaySainiDell,
bpjain2004,
donatwork and
tdawe
as code owners
December 19, 2024 14:54
falfaroc
requested review from
JacobGros,
harshitap26,
atye,
xuluna,
EvgenyUglov,
shaynafinocchiaro,
anathoodell and
lukeatdell
December 19, 2024 15:00
tdawe
reviewed
Dec 19, 2024
tdawe
reviewed
Dec 19, 2024
tdawe
reviewed
Dec 19, 2024
xuluna
previously approved these changes
Dec 19, 2024
tdawe
previously approved these changes
Dec 19, 2024
lukeatdell
previously approved these changes
Dec 19, 2024
falfaroc
dismissed stale reviews from lukeatdell, tdawe, and xuluna
via
December 19, 2024 20:07
fd77e96
lukeatdell
approved these changes
Dec 19, 2024
tdawe
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the mult-availability zone support to PowerFlex.
This feature allows the user to use a single storage class with multiple zones such that when a volume is provisioned using that storage class, PowerFlex flex will determine which zone is available and preferred. We rely on kubernetes topology mechanism to achieve proper zoning.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration