Fix UT

dell · Nov 25, 2024 · 0e29736 · 0e29736
1 parent 84d7f67
commit 0e29736
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/service/features/migration.feature b/service/features/migration.feature
@@ -82,7 +82,8 @@ Feature: PowerMax CSI Interface
     And I call ArrayMigrate with <actionvalue>
     And the error contains <errormsg>
     Examples:
-      | actionvalue                            | errormsg                  |
-      | "csimgr.ActionTypes_MG_MIGRATE"        | "none"                    |
-      | "csimgr.ActionTypes_MG_COMMIT"         | "none"                    |
-      | ""                                     | "none"                    |
+      | actionvalue                            | errormsg                                                        |
+      | "csimgr.ActionTypes_MG_MIGRATE"        | "failed to create array migration environment for target array" |
+      | "csimgr.ActionTypes_MG_COMMIT"         | "Not Found"                                                     |
+      | ""                                     | "Invalid action"                                                |
+
diff --git a/service/step_defs_test.go b/service/step_defs_test.go
@@ -479,6 +479,7 @@ ip6t_rpfilter          12595  1
 	svc.fcConnector = &mockFCGobrick{}
 	svc.iscsiConnector = &mockISCSIGobrick{}
 	svc.nvmetcpClient = &gonvme.MockNVMe{}
+	svc.nvmeTCPConnector = &mockNVMeTCPConnector{}
 	svc.dBusConn = &mockDbusConnection{}
 	svc.k8sUtils = k8smock.Init()
 	mockGobrickReset()
@@ -3567,6 +3568,10 @@ func (f *feature) iSetTransportProtocolTo(protocol string) error {
 		f.service.useNVMeTCP = false
 		f.service.useFC = false
 		f.service.useIscsi = true
+	case "NVME":
+		f.service.useNVMeTCP = true
+		f.service.useFC = false
+		f.service.useIscsi = false
 	}
 	f.service.opts.TransportProtocol = protocol
 	return nil
@@ -4827,7 +4832,10 @@ func (f *feature) iCallArrayMigrate(actionvalue string) error {
 			SymmetrixIDParam: mock.DefaultSymmetrixID,
 			RemoteSymIDParam: mock.DefaultRemoteSymID,
 		},
-		ActionTypes: iActionValue(actionvalue),
+	}
+	action := iActionValue(actionvalue)
+	if action != nil {
+		req.ActionTypes = action
 	}
 
 	f.arrayMigrateResponse, f.err = f.service.ArrayMigrate(ctx, req)