Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding link to runtime dependencies in README file #251

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Conversation

boyamurthy
Copy link
Contributor

@boyamurthy boyamurthy commented Nov 24, 2023

Updating Readme files

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1056

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

shanmydell
shanmydell previously approved these changes Nov 24, 2023
README.md Outdated Show resolved Hide resolved
@gallacher gallacher changed the title Updating Readme Adding link to runtime dependencies in README file Nov 24, 2023
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanmydell shanmydell self-requested a review November 27, 2023 06:13
@shanmydell shanmydell merged commit 749c714 into main Nov 27, 2023
3 of 4 checks passed
@shanmydell shanmydell deleted the update_readme branch November 27, 2023 06:22
Sahiba-Gupta pushed a commit that referenced this pull request Oct 11, 2024
Co-authored-by: Yamunadevi N Shanmugam <82038610+shanmydell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants