Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage enhanced for service.go in PowerScale #102

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

Sakshi-dell
Copy link
Collaborator

Description

This PR is to enhance the code coverage for service.go to reach the overall code coverage target of 80% for CSI-PowerScale.

Existing coverage:
overall: 65.9%
service.go: 70.2%

Current coverage:
overall: 67.7%
service.go: 81.0%

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#350

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Changes are only done in unit test-related files and unit tests are running successfully
  • Test B

Copy link
Contributor

@meggm meggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randeepdell randeepdell merged commit e72610b into main Jul 7, 2022
@randeepdell randeepdell deleted the code-coverage-enhancement-service.go branch July 7, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants