Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add root clients to RO volume from snapshot #111

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

randeepdell
Copy link
Contributor

Description

In Powerscale read only client privileges supersedes all privileges, hence adding to root-clients has no effect.
One of the customer would like to traverse files irrespective of owner permissions when RootClientEnabled is set to true.
Hence Read Only PVC created from snapshot is added only to root clients instead of read only clients when Root Client Enabled is set to true.

In the case of source PVC being in non-system access zone, when pvc from snapshot is created, the AzService IP to be supplied in the storage class in restore needs to be the isi endpoint and not the AzService IP of the access zone, as the snapshot is created in the System access zone and not the source access zone.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#362

Checklist:

  • [x ] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built the code, created sc, pvc, pod, snapshot, pvc from snapshot and tested the same.

@randeepdell randeepdell changed the title Feature 362 add r ovol root clients Add root clients to RO volume from PVC Aug 3, 2022
@randeepdell randeepdell changed the title Add root clients to RO volume from PVC Add root clients to RO volume from snapshot Aug 3, 2022
@prablr79
Copy link
Collaborator

prablr79 commented Aug 3, 2022

@randeepsharma can you also share code coverage for this PR ?

@randeepdell
Copy link
Contributor Author

@randeepsharma can you also share code coverage for this PR ?

coverage: 72.8% of statements

@nitesh3108 nitesh3108 merged commit 0b20979 into main Aug 3, 2022
@randeepdell randeepdell deleted the feature-362-addROvol-root-clients branch August 4, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants