Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed independent deletion of RO snapshot and UT #216

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

shefali-malhotra
Copy link
Collaborator

Description

  • Added access zone in snapshot handler to access the zone name while deletion of snapshot.
  • FIxed UT test cases

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#487

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Unit Test cases

image

  • Validated independent deletion of RO snapshot and volume.

Copy link
Contributor

@meggm meggm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shefali-malhotra shefali-malhotra merged commit 066e908 into main Aug 30, 2023
@shefali-malhotra shefali-malhotra deleted the UT_fix branch August 30, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants