Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/stand alone helm #129

Merged
merged 12 commits into from
Jul 4, 2022
Merged

Feature/stand alone helm #129

merged 12 commits into from
Jul 4, 2022

Conversation

harishp8889
Copy link
Collaborator

@harishp8889 harishp8889 commented Jul 4, 2022 •
edited
Loading

Description

Updated handling of 1.24.x Kubernetes verification

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#355

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on Kubernetes 1.24.2

@harishp8889 harishp8889 self-assigned this Jul 4, 2022
gilltaran
gilltaran previously approved these changes Jul 4, 2022
View reviewed changes
@harishp8889 harishp8889 merged commit 1f693ad into main Jul 4, 2022
@harishp8889 harishp8889 deleted the feature/stand-alone-helm branch August 11, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spriya-m spriya-m spriya-m approved these changes

@harshitap26 harshitap26 harshitap26 approved these changes

@gilltaran gilltaran gilltaran left review comments

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@prablr79 prablr79 Awaiting requested review from prablr79

Assignees

@harishp8889 harishp8889

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harishp8889 @harshitap26 @gilltaran @spriya-m