Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go mod references for dell-csi-extensions #272

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Update go mod references for dell-csi-extensions #272

merged 3 commits into from
Sep 6, 2023

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Sep 5, 2023 •
edited
Loading

Description

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@santhoshatdell santhoshatdell marked this pull request as ready for review September 5, 2023 15:37
@santhoshatdell santhoshatdell marked this pull request as draft September 5, 2023 15:51
donatwork
donatwork previously approved these changes Sep 5, 2023
View reviewed changes
ChristianAtDell
ChristianAtDell previously approved these changes Sep 5, 2023
View reviewed changes
@santhoshatdell santhoshatdell marked this pull request as ready for review September 5, 2023 18:30
AkshaySainiDell
AkshaySainiDell approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@santhoshatdell santhoshatdell merged commit 36005b8 into main Sep 6, 2023
@santhoshatdell santhoshatdell deleted the go-mod-update-for-dell-csi-extensions branch September 6, 2023 13:06
@santhoshatdell santhoshatdell mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@harshaatdell harshaatdell harshaatdell approved these changes

@donatwork donatwork donatwork approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@prablr79 prablr79 Awaiting requested review from prablr79

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@gilltaran gilltaran Awaiting requested review from gilltaran

@kenivi1 kenivi1 Awaiting requested review from kenivi1

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@santhoshatdell @donatwork @harshaatdell @AkshaySainiDell @adarsh-dell @ChristianAtDell