Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/csi 1.6 #278

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Feature/csi 1.6 #278

merged 2 commits into from
Oct 23, 2023

Conversation

adarsh-dell
Copy link
Contributor

@adarsh-dell adarsh-dell commented Oct 10, 2023 •
edited
Loading

Description

CSI Spec v1.6.0 support.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#905

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran UT.
    image

  • Tried to create a pod with PVC, with size of more than the maxVolumeSize supported by array. And as expected found the error.
    image
    image

@adarsh-dell adarsh-dell marked this pull request as ready for review October 19, 2023 09:16
suryagupta4
suryagupta4 previously approved these changes Oct 20, 2023
View reviewed changes
AkshaySainiDell
AkshaySainiDell approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adarsh-dell adarsh-dell merged commit da6b508 into main Oct 23, 2023
3 of 4 checks passed
@shanmydell shanmydell deleted the feature/CSI-1.6 branch January 31, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@prablr79 prablr79 Awaiting requested review from prablr79

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@gilltaran gilltaran Awaiting requested review from gilltaran

@kenivi1 kenivi1 Awaiting requested review from kenivi1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adarsh-dell @AkshaySainiDell @suryagupta4