Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dell-csi-helm-installer #193

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: update dell-csi-helm-installer #193

merged 2 commits into from
Mar 5, 2024

Conversation

mdutka-dell
Copy link
Contributor

@mdutka-dell mdutka-dell commented Feb 26, 2024 •
edited
Loading

Description

Update dell-csi-helm-installer to CSM release 2.10.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@mdutka-dell mdutka-dell changed the title update installer fix: update dell-csi-helm-installer Feb 26, 2024
@alikdell
Copy link
Contributor

alikdell commented Mar 4, 2024

Why linting errors are not fix as part of PRs?

@adamginna-dell adamginna-dell merged commit c73c5ba into main Mar 5, 2024
3 of 4 checks passed
@alikdell alikdell deleted the update_install_sh branch March 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leonard-Dell Leonard-Dell Leonard-Dell approved these changes

@adamginna-dell adamginna-dell adamginna-dell approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdutka-dell @alikdell @adamginna-dell @Leonard-Dell