Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goclient versions #194

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update goclient versions #194

merged 1 commit into from
Mar 5, 2024

Conversation

xuluna
Copy link
Contributor

@xuluna xuluna commented Mar 1, 2024

Description

Update go clients to new release version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1091

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Integration test with cert-csm
[2024-03-04 18:10:31]  INFO Avg time of a run:	 125.57s
[2024-03-04 18:10:31]  INFO Avg time of a del:	 18.02s
[2024-03-04 18:10:31]  INFO Avg time of all:	 151.32s
[2024-03-04 18:10:31]  INFO During this run 100.0% of suites succeeded
CMD RETURNCODE IS: 0
ALL CERT-CSI RETURNCODEs: 0,0,0,0,0
All test(s) passed

alikdell
alikdell previously approved these changes Mar 1, 2024
EvgenyUglov
EvgenyUglov previously approved these changes Mar 1, 2024
@mdutka-dell
Copy link
Contributor

Did you test changes?

@xuluna xuluna force-pushed the luna/update-release branch 2 times, most recently from abd7bcd to 310b92e Compare March 4, 2024 22:02
@xuluna
Copy link
Contributor Author

xuluna commented Mar 4, 2024

Did you test changes?

Yes, did integration test passed with cert-csm, updated the PR description.

@xuluna xuluna force-pushed the luna/update-release branch from 310b92e to e7cfb6d Compare March 5, 2024 14:52
@xuluna xuluna dismissed stale reviews from EvgenyUglov and alikdell via c04853d March 5, 2024 14:55
@xuluna xuluna force-pushed the luna/update-release branch from d419771 to a1a8b02 Compare March 5, 2024 15:00
fix format

fix format

fix linting

update gobrick

update gobrick

Signed-off-by: Luna Xu <luna.xu@dell.com>
Signed-off-by: Luna Xu <ms.luna.xu@gmail.com>
@xuluna xuluna force-pushed the luna/update-release branch from a1a8b02 to 700f8f4 Compare March 5, 2024 15:09
@xuluna xuluna merged commit ab61d0d into main Mar 5, 2024
4 checks passed
@xuluna xuluna deleted the luna/update-release branch March 5, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants