Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected-UBI #35

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Corrected-UBI #35

merged 1 commit into from
Sep 6, 2022

Conversation

kumarkgosa
Copy link
Contributor

@kumarkgosa kumarkgosa commented Sep 6, 2022 •
edited by gallacher
Loading

Description

Correcting the UBI Image

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#465

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@kumarkgosa kumarkgosa requested a review from abhi16394 September 6, 2022 20:35
@abhi16394 abhi16394 requested review from abhi16394, bharathsreekanth, JacobGros and jooseppi-luna and removed request for mbasha-dell September 6, 2022 20:37
@kumarkgosa kumarkgosa requested review from mbasha-dell and removed request for jooseppi-luna, JacobGros and abhi16394 September 6, 2022 20:37
mbasha-dell
mbasha-dell approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@mbasha-dell mbasha-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kumarkgosa kumarkgosa merged commit 4a258d4 into main Sep 6, 2022
@kumarkgosa kumarkgosa deleted the amd64-UBI branch September 6, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasha-dell mbasha-dell mbasha-dell approved these changes

@abhi16394 abhi16394 abhi16394 approved these changes

@JacobGros JacobGros JacobGros approved these changes

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumarkgosa @JacobGros @abhi16394 @mbasha-dell