Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes to use common Golang version update #62

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

shefali-malhotra
Copy link
Contributor

Description

Added changes to use common Golang version update

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Verified the build
    image
    image

@panigs7
Copy link

panigs7 commented Feb 20, 2024

@shefali-malhotra The github actions for go fmt, lint and vet is failing. Please check it. Thanks!

@adarsh-dell
Copy link
Contributor

@shefali-malhotra Can you please fix this check?
image

@shefali-malhotra shefali-malhotra merged commit d8aee77 into main Feb 20, 2024
2 of 4 checks passed
@shefali-malhotra shefali-malhotra deleted the go_version_update branch February 20, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants