Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi powerscale 2.4 related updates #313

Merged
merged 3 commits into from
Aug 17, 2022
Merged

csi powerscale 2.4 related updates #313

merged 3 commits into from
Aug 17, 2022

Conversation

randeepdell
Copy link
Contributor

@randeepdell randeepdell commented Aug 12, 2022 •
edited
Loading

Description

2.4 driver version related changes.
Add feature implemented in 2.4 driver.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#362
dell/csm#350

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@randeepdell randeepdell changed the title <WIP> Update csi powerscale 2.4 csi powerscale 2.4 related updates Aug 17, 2022
@randeepdell randeepdell marked this pull request as ready for review August 17, 2022 05:27
rsedlock1958
rsedlock1958 reviewed Aug 17, 2022
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. One minor edit.

Sakshi-dell
Sakshi-dell approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@Sakshi-dell Sakshi-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rsedlock1958
rsedlock1958 reviewed Aug 17, 2022
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No edits required.

nitesh3108
nitesh3108 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@nitesh3108 nitesh3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randeepdell randeepdell merged commit 4f72e66 into release-1.4-updated Aug 17, 2022
@randeepdell randeepdell deleted the update-csi-powerscale-2.4 branch August 17, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@shanmydell shanmydell shanmydell approved these changes

@Sakshi-dell Sakshi-dell Sakshi-dell approved these changes

@gallacher gallacher Awaiting requested review from gallacher

@mjsdell mjsdell Awaiting requested review from mjsdell

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@prablr79 prablr79 Awaiting requested review from prablr79

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@randeepdell @prablr79 @Sakshi-dell @rsedlock1958 @shanmydell @nitesh3108