Common-section-for-Volume-Snapshot #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgandharva
requested review from
bharathsreekanth,
Deepak-Ghivari,
gallacher,
mjsdell,
prablr79,
rajendraindukuri,
rajkumar-palani,
rsedlock1958 and
shanmydell
as code owners
bharathsreekanth
requested changes
May 16, 2023
content/docs/snapshots/_index.md
Outdated
| ```bash | ||
| git clone https://github.com/kubernetes-csi/external-snapshotter/ | ||
| cd ./external-snapshotter | ||
| git checkout release-<your-version> ---> Reference the current version. |
There was a problem hiding this comment.
What is Reference the current version pointing to ? Is it a link? If we know the specific version, such as 6.2.x then can we not say "git checkout release-6.2.0" in that step?
content/docs/snapshots/_index.md
Outdated
|
|
||
| ### (Optional) Volume Snapshot Requirements | ||
|
|
||
| Applicable only if you decided to enable snapshot feature in `values.yaml` |
|
I have done the changes as per the given comments, please let me know if there are any other changes required. |
bharathsreekanth
approved these changes
May 16, 2023
| ```bash | ||
| git clone https://github.com/kubernetes-csi/external-snapshotter/ | ||
| cd ./external-snapshotter | ||
| git checkout release-6.2.0 |
There was a problem hiding this comment.
Just make sure this is the correct version. I was only referring to having a version here so that users can copy-paste these lines if needed without edits, but I would still confirm if all the teams are using 6.2.0 or another version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a common section for Volume Snapshot Requirements that all the CSI driver Helm installation reference.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: