NFS volume support for CSI-PowerFlex driver #755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khareRajshree
requested review from
bharathsreekanth,
chimanjain,
Deepak-Ghivari,
gallacher,
mgandharva,
mjsdell,
prablr79,
rajendraindukuri,
rajkumar-palani,
rsedlock1958 and
shanmydell
as code owners
sharont58
reviewed
Aug 17, 2023
| To enable the support of NFS volumes operations from CSI driver, there are a few new keys introduced which needs to be set before performing the operations for NFS volumes. | ||
| * `nasName`: defines the NAS server name that should be used for NFS volumes. | ||
| * `nfsAcls`: defines permissions - POSIX mode bits or NFSv4 ACLs, to be set on NFS target mount directory. NFSv4 ACLs are supported for NFSv4 shares on NFSv4 enabled NAS servers only. POSIX ACLs are not supported and only POSIX mode bits are supported for NFSv3 shares. | ||
| * `externalAccess`: allows to specify additional entries for host to access NFS volumes. |
sharont58
reviewed
Aug 17, 2023
| ... | ||
| ``` | ||
|
|
||
| Let us assume the user creates a PVC with 3 Gi of storage and quotas have already been enabled in PowerFlex system for the specified volume. |
There was a problem hiding this comment.
For example, if the user creates ....
sharont58
reviewed
Aug 17, 2023
| When `enableQuota` is set to `true` | ||
|
|
||
| * The driver sets the hard limit of the PVC to 3Gi. | ||
| * The user adds data of 2Gi to the above said PVC (by logging into POD). It works as expected. |
There was a problem hiding this comment.
... to the PVC ...
{remove above said}
sharont58
reviewed
Aug 17, 2023
| When `enableQuota` is set to `false` | ||
|
|
||
| * Driver doesn't set any hard limit against the PVC created. | ||
| * The user adds data of 2Gi to the above said PVC, which is having the size 3Gi (by logging into POD). It works as expected. |
There was a problem hiding this comment.
The user adds 2Gi data to the PVC, which has a limit of 3Gi. It works as expected.
{I don't understand the (by logging into POD) statement. Do you add data by logging in to PVC? IN which case that should be at the start of the sentence:
The user logs into the POD and adds 2Gi data to the PVC, which has a limit of 3Gi.
sharont58
reviewed
Aug 17, 2023
| ```yaml | ||
| ... | ||
| ... | ||
| # externalAccess: allows to specify additional entries for host to access NFS volumes. Both single IP address and subnet are valid entries. |
done |
mgandharva
reviewed
Aug 18, 2023
| # Allowed values: | ||
| # 1) Unix mode: valid octal mode number | ||
| # Examples: "0777", "777", "0755" | ||
| # 2) NFSv4 acls: valid NFSv4 acls, seperated by comma |
mgandharva
reviewed
Aug 18, 2023
VamsiSiddu-7
previously approved these changes
Aug 18, 2023
Done. |
VamsiSiddu-7
previously approved these changes
Aug 18, 2023
|
Hi @sharont58 can you please review the changes after recent commits. Thanks. |
ashleyvjoy
previously approved these changes
Aug 21, 2023
khareRajshree
dismissed stale reviews from ashleyvjoy and VamsiSiddu-7
via
5ad7d1c
sharont58
previously approved these changes
Aug 21, 2023
khareRajshree
force-pushed
the
powerflex-nfs-support
branch
from
bb962cc to
f5cb866
Compare
Added Support for 1.28 for observability
khareRajshree
force-pushed
the
powerflex-nfs-support
branch
from
f5cb866 to
89fa167
Compare
khareRajshree
force-pushed
the
powerflex-nfs-support
branch
from
89fa167 to
6c6f70a
Compare
* update sdc to 3.6.1 * updated release notes
khareRajshree
force-pushed
the
powerflex-nfs-support
branch
from
6c6f70a to
10c2224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to add documentation support for NFS volume support in CSI-PowerFlex driver.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: