-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity installation changes for central helm #789
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fc266f2
Updated the unity helm installation changes in document
karthikk92 942370b
Updated the unity helm installation changes in document
karthikk92 f4a7119
Addressed review comment
karthikk92 9117639
Addressed review comment on gut hub ulr update
karthikk92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,7 +92,7 @@ Install CSI Driver for Unity XT using this procedure. | |
|
||
* As a pre-requisite for running this procedure, you must have the downloaded files, including the Helm chart from the source [git repository](https://github.com/dell/csi-unity) with the command | ||
```bash | ||
git clone -b v2.7.0 https://github.com/dell/csi-unity.git | ||
git clone -b v2.8.0 https://github.com/dell/csi-unity.git | ||
``` | ||
* In the top-level dell-csi-helm-installer directory, there should be two scripts, `csi-install.sh` and `csi-uninstall.sh`. | ||
* Ensure _unity_ namespace exists in Kubernetes cluster. Use the `kubectl create namespace unity` command to create the namespace if the namespace is not present. | ||
|
@@ -107,13 +107,17 @@ Procedure | |
* ArrayId corresponds to the serial number of Unity XT array. | ||
* Unity XT Array username must have role as Storage Administrator to be able to perform CRUD operations. | ||
* If the user is using a complex K8s version like "v1.24.6-mirantis-1", use this kubeVersion check in helm/csi-unity/Chart.yaml file. | ||
kubeVersion: ">= 1.24.0-0 < 1.28.0-0" | ||
kubeVersion: ">= 1.24.0-0 < 1.29.0-0" | ||
|
||
2. Copy the `helm/csi-unity/values.yaml` into a file named `myvalues.yaml` in the same directory of `csi-install.sh`, to customize settings for installation. | ||
2. Get the required values.yaml using below command | ||
|
||
3. Edit `myvalues.yaml` to set the following parameters for your installation: | ||
```bash | ||
cd dell-csi-helm-installer && wget -O my-unity-settings.yaml -b <version> https://raw.githubusercontent.com/dell/helm-charts/main/charts/csi-unity/values.yaml | ||
``` | ||
|
||
3. Edit `values.yaml` to set the following parameters for your installation: | ||
|
||
The following table lists the primary configurable parameters of the Unity XT driver chart and their default values. More detailed information can be found in the [`values.yaml`](https://github.com/dell/csi-unity/blob/master/helm/csi-unity/values.yaml) file in this repository. | ||
The following table lists the primary configurable parameters of the Unity XT driver chart and their default values. More detailed information can be found in the [`values.yaml`](https://raw.githubusercontent.com/dell/helm-charts/main/charts/csi-unity/values.yaml) file in this repository. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are we not using link "https://github.com/dell/helm-charts/blob/main/charts/csi-unity/values.yaml" instead of the raw content? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Taken care |
||
|
||
| Parameter | Description | Required | Default | | ||
| --------- | ----------- | -------- |-------- | | ||
|
@@ -320,6 +324,14 @@ Procedure | |
------------------------------------------------------ | ||
``` | ||
|
||
OR | ||
To install particular version | ||
```bash | ||
cd dell-csi-helm-installer && wget -O my-unity-settings.yaml -b <version> https://raw.githubusercontent.com/dell/helm-charts/main/charts/csi-unity/values.yaml && | ||
|
||
./csi-install.sh --namespace unity --values my-unity-settings.yaml --helm-charts-version <version> | ||
``` | ||
|
||
Results: | ||
|
||
At the end of the script unity-controller Deployment and DaemonSet unity-node will be ready, execute command `kubectl get pods -n unity` to get the status of the pods and you will see the following: | ||
|
@@ -330,7 +342,7 @@ Procedure | |
**Note**: | ||
To install nightly or latest csi driver build using bash script use this command: | ||
```bash | ||
/csi-install.sh --namespace unity --values ./myvalues.yaml --version latest | ||
/csi-install.sh --namespace unity --values ./myvalues.yaml --version latest --helm-charts-version <version> | ||
``` | ||
|
||
8. You can also install the driver using standalone helm chart by cloning the centralised helm charts and running the helm install command as shown. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the command below
or
using the following command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken care @sharont58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sharont58 Could you please review and approve this PR ?