Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade OTEL version to v1.7.0. #35

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

taohe1012
Copy link
Contributor

@taohe1012 taohe1012 commented Jul 8, 2022

Description

upgrade OTEL version to v1.7.0:

  • upgrade otel version to 1.7.0, and its subpackages to v0.30.0;
  • use Async UpDownCounter instead of Sync UpDownCounter;

Note: we upgrade the OpenTelemetry to v1.7.0, and its subpackages to v0.30.0, to use Async UpDownCounter instead of Sync UpDownCounter.

According official reference, UpDownCounter :
For fetching the snapshot of the “current value” is straightforward, use Asynchronous UpDownCounter instead, not Synchronous UpDownCounter.

GitHub Issues

GitHub Issue #
dell/csm#454

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

  • Test A: UT tests

ut_results

  • Test B: Grafana PowerStore Volume IO Metrics: checked it value is consistent with PStore Mgmt UI's volume value
    PStore Mgmt UI:

GUI_vol_performance

Grafana:

grafana_vol_performance

  • Test C: Grafana PowerStore FileSystem IO Metrics: checked it value is consistent with PStore Mgmt UI's nfs volume value
    PStore Mgmt UI:

GUI_nfs_performance

Grafana:

grafana_nfs_performance

  • Test D: Grafana PowerStore Storage Class Capacity:
    Grafana:

grafana_storageclass_cap_1

grafana_storageclass_cap_2_array

grafana_storageclass_cap_3_array

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@atye
Copy link

atye commented Jul 8, 2022

Can one of the admins verify this patch?

@taohe1012
Copy link
Contributor Author

run e2e test

forrestxia
forrestxia previously approved these changes Jul 8, 2022
baoy1
baoy1 previously approved these changes Jul 8, 2022
@taohe1012 taohe1012 dismissed stale reviews from baoy1 and forrestxia via 33fa888 July 8, 2022 07:50
@taohe1012 taohe1012 force-pushed the feature-354-pstoreMetrics-upgrade-otel branch from 386b6a7 to 33fa888 Compare July 8, 2022 07:50
@taohe1012
Copy link
Contributor Author

run e2e test

@taohe1012
Copy link
Contributor Author

e2e pass

@taohe1012 taohe1012 merged commit 1f33bef into main Jul 11, 2022
@taohe1012 taohe1012 deleted the feature-354-pstoreMetrics-upgrade-otel branch July 11, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants