Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powerflex: support added for NFS #315

Closed
wants to merge 5 commits into from
Closed

Conversation

khareRajshree
Copy link
Contributor

@khareRajshree khareRajshree commented Aug 7, 2023

Description

Changes added for NFS support in PowerFlex.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#763

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit test (refer GitHub actions workflow)
  • Functional test, executed 1vol-nfs helm test

controller pod with env vars set for driver:

driver:
    Container ID:  containerd://b2939bxxxxxxxxxxxx
    Image:         <local-artifactory>:5036/csi-vxflexos:vmain-latest
    Image ID:      <local-artifactory>:5036/csi-vxflexos@sha256:c23420xxxxxxxxxxxx
    Port:          <none>
    Host Port:     <none>
    Command:
      /csi-vxflexos.sh
    Args:
      --leader-election
      --array-config=/vxflexos-config/config
      --driver-config-params=/vxflexos-config-params/driver-config-params.yaml
    State:          Running
      Started:      Mon, 07 Aug 2023 08:40:10 -0400
    Ready:          True
    Restart Count:  0
    Environment:
      CSI_ENDPOINT:                             /var/run/csi/csi.sock
      X_CSI_MODE:                               controller
      X_CSI_VXFLEXOS_ENABLESNAPSHOTCGDELETE:    false
      X_CSI_VXFLEXOS_ENABLELISTVOLUMESNAPSHOT:  false
      SSL_CERT_DIR:                             /certs
      X_CSI_HEALTH_MONITOR_ENABLED:             false
      X_CSI_NFS_ACLS:                           0777
      X_CSI_POWERFLEX_EXTERNAL_ACCESS:
      X_CSI_QUOTA_ENABLED:                      true

1vol-nfs test events:

Events:
  Type    Reason                  Age   From                     Message
  ----    ------                  ----  ----                     -------
  Normal  Scheduled               22s   default-scheduler        Successfully assigned helmtest-vxflexos/vxflextest-0 to worker-1-k8vqcgtjmfu8k.domain
  Normal  SuccessfulAttachVolume  20s   attachdetach-controller  AttachVolume.Attach succeeded for volume "k8s-46a5c22bc9"
  Normal  Pulling                 14s   kubelet                  Pulling image "docker.io/centos:latest"
  Normal  Pulled                  14s   kubelet                  Successfully pulled image "docker.io/centos:latest" in 533.962187ms (533.981681ms including waiting)
  Normal  Created                 14s   kubelet                  Created container test
  Normal  Started                 14s   kubelet                  Started container test
10.x.x.x:/k8s-46a5c22bc9   8388608  1582336   6806272  19% /data0
10.x.x.x:/k8s-46a5c22bc9 on /data0 type nfs4 (rw,relatime,vers=4.2,rsize=262144,wsize=262144,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=10.x.x.x,local_lock=none,addr=10.x.x.x)

@bharathsreekanth
Copy link
Collaborator

I see some internal IPs listed in the output of how it was tested. Let us try to avoid posting those IPs in PRs, etc.

@khareRajshree
Copy link
Contributor Author

I see some internal IPs listed in the output of how it was tested. Let us try to avoid posting those IPs in PRs, etc.

Done.

@mjsdell mjsdell deleted the pflx-nfs-support branch October 17, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants