Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

velero upgrade to v1.14.0 #619

Merged
merged 18 commits into from
Jul 16, 2024
Merged

velero upgrade to v1.14.0 #619

merged 18 commits into from
Jul 16, 2024

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Jul 3, 2024 •
edited
Loading

Description

velero upgrade to v1.14.0

Note: Due to the increase from velero v1.10.x to velero v1.14.0, the node-agent daemonset needs to be renamed to remove the application-mobility- prefix. This is due to a check within velero v1.14.0 when processing the restores (https://github.com/vmware-tanzu/velero/blob/2fc6300f2239f250b40b0488c35feae59520f2d3/pkg/podvolume/restorer.go#L119). After testing with those changes and updating the velero crds to match the latest v1.14.0, no issues were seen during testing.

Note: This partially fixes the running sanity tests.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Complete e2e tests were run on a multi-cluster k8s 1.30 setup to ensure that all variations of clones
  • Run sanity e2e test and add AM upgrade/downgrade test

image

AkshaySainiDell
AkshaySainiDell previously approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kumarkgosa
kumarkgosa reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@kumarkgosa kumarkgosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested this version for a successful backup and restore ? result success screenshot would've been nice.

alikdell
alikdell previously approved these changes Jul 15, 2024
View reviewed changes
donatwork
donatwork previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@donatwork donatwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline is failing on the YAML linters.

pkg/modules/application_mobility_test.go Show resolved Hide resolved
EvgenyUglov
EvgenyUglov previously approved these changes Jul 15, 2024
View reviewed changes
@shaynafinocchiaro
Copy link
Contributor

All commits have to be signed.

@suryagupta4 suryagupta4 merged commit 2a65ff7 into main Jul 16, 2024
8 of 9 checks passed
@AkshaySainiDell AkshaySainiDell mentioned this pull request Jul 16, 2024
Closed
10 tasks
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell @falfaroc
@JacobGros @abhi16394
velero upgrade to v1.14.0 (#619)
91da025 
* velero upgrade

* update new velero crds

* velero-plugin-for-aws version upgrade

* Update node agent and velero crds for v1.14.0

* Remove node agent when performing AM upgrade  (#627)

* try removing older node agent

* add namespace substitute to old path

* fix replace

* move check to AM

* add var to modules

* fix small error

* fix check

* add debug logging

* try status fix

* return fmt error

* return fmt error

* remove debugging lohs

* fix lint

* fix lint

* gofumpt

* prevent short circuit

* add UT for AppMobilityVelero

* Fix sanity e2e tests

* Revert auth storage templates

* Revert auth storage templates

* Fix incorrect replace name for auth

* Add e2e test (#629)

* add e2e test for defect fix

* fix upgrade

* fix upgrade

* add downgrade test

* fix title

* Migrate application mobility upgrade to scenarios file

* Change config version

* Fix application mobility e2e tests

---------

Co-authored-by: Fernando Alfaro Campos <Fernando.Alfaro_campos@Dell.com>
Co-authored-by: JacobGros <jacobgrosner4@gmail.com>
Co-authored-by: abhi16394 <abhi.muralidhara@dell.com>
@mjsdell mjsdell deleted the velero-upgrade branch October 17, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@falfaroc falfaroc Awaiting requested review from falfaroc

@donatwork donatwork Awaiting requested review from donatwork

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.