Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity client upgrade e2e #633

Merged
merged 2 commits into from
Jul 16, 2024
Merged

connectivity client upgrade e2e #633

merged 2 commits into from
Jul 16, 2024

Conversation

nitesh3108
Copy link
Contributor

@nitesh3108 nitesh3108 commented Jul 16, 2024

Description

This PR includes following changes to connectivity client e2e test-cases

  • Refactored existing connectivity client e2e testcases
  • Added Upgrade scenarios e2e tests
  • Secret create/delete e2e
  • Split the execution block to first check its kind and then execute (ContainerStorageModule / ApexConnectivityClient)

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1396

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Scenario: "Upgrade APEX Connectivity Client"
Running Suite: CSM Operator End-to-End Tests - /root/map-sync/csm-operator/tests/e2e
====================================================================================
Random Seed: 1721136114

Will run 1 of 1 specs
------------------------------
[BeforeSuite]
/root/map-sync/csm-operator/tests/e2e/e2e_test.go:81
  STEP: Getting test environment variables @ 07/16/24 09:22:02.99
  STEP: [sanity] @ 07/16/24 09:22:02.99
  STEP: Reading values file @ 07/16/24 09:22:02.99
  STEP: Reading apex values file @ 07/16/24 09:22:03.003
  STEP: Getting a k8s client @ 07/16/24 09:22:03.004
[BeforeSuite] PASSED [0.017 seconds]
------------------------------
[run-e2e-test] E2E Testing Running all test Given Test Scenarios
/root/map-sync/csm-operator/tests/e2e/e2e_test.go:139
  STEP: Starting: Upgrade APEX Connectivity Client  @ 07/16/24 09:22:03.007
  STEP:      Executing  Given an client environment with k8s or openshift, and CSM operator installed @ 07/16/24 09:22:03.007
  STEP:      Executing  Install connectivity client from CR [1] and create secret [3] @ 07/16/24 09:22:03.018
  Jul 16 09:22:03.020: INFO: Running '/usr/bin/kubectl --namespace=dell-connectivity-client apply --validate=true -f -'
  Jul 16 09:22:03.183: INFO: stderr: ""
  Jul 16 09:22:03.183: INFO: stdout: "apexconnectivityclient.storage.dell.com/dell-connectivity-client created\n"
  Jul 16 09:22:03.184: INFO: Running '/usr/bin/kubectl --namespace=dell-connectivity-client apply --validate=true -f -'
  Jul 16 09:22:03.607: INFO: stderr: ""
  Jul 16 09:22:03.608: INFO: stdout: "secret/connectivity-client-docker-k8s-loadbalancer-ca-cert created\nsecret/connectivity-client-docker-k8s-aggregator-internal-ca-cert created\nsecret/connectivity-client-docker-k8s-cert created\n"
  STEP:      Executing  Validate connectivity client from CR [1] is installed @ 07/16/24 09:22:03.608
  STEP:      Executing  Upgrade client from custom resource [1] to [2] @ 07/16/24 09:23:13.62
  STEP:      Executing  Validate connectivity client from CR [2] is installed @ 07/16/24 09:23:13.627
  STEP:      Executing  Uninstall connectivity client from CR [2] @ 07/16/24 09:24:23.635
  Jul 16 09:24:23.637: INFO: Running '/usr/bin/kubectl --namespace=dell-connectivity-client delete --wait=true --timeout=30s -f -'
  Jul 16 09:24:23.839: INFO: stderr: ""
  Jul 16 09:24:23.839: INFO: stdout: "apexconnectivityclient.storage.dell.com \"dell-connectivity-client\" deleted\n"
  STEP:      Executing  Uninstall connectivity client secret from CR [3] @ 07/16/24 09:24:23.839
  Jul 16 09:24:23.843: INFO: Running '/usr/bin/kubectl --namespace=dell-connectivity-client delete --wait=true --timeout=30s -f -'
  Jul 16 09:24:23.953: INFO: stderr: ""
  Jul 16 09:24:23.953: INFO: stdout: "secret \"connectivity-client-docker-k8s-loadbalancer-ca-cert\" deleted\nsecret \"connectivity-client-docker-k8s-aggregator-internal-ca-cert\" deleted\nsecret \"connectivity-client-docker-k8s-cert\" deleted\n"
  STEP:      Executing  Validate connectivity client from CR [2] is not installed @ 07/16/24 09:24:23.953
  STEP: Ending: Upgrade APEX Connectivity Client
   @ 07/16/24 09:24:43.957
• [165.955 seconds]
------------------------------

Ran 1 of 1 Specs in 165.972 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

@nitesh3108 nitesh3108 force-pushed the client-e2e-upgrade-test branch from e75221d to c1850b8 Compare July 16, 2024 14:04
@nitesh3108 nitesh3108 merged commit ef11379 into main Jul 16, 2024
8 of 9 checks passed
@nitesh3108 nitesh3108 deleted the client-e2e-upgrade-test branch July 16, 2024 14:22
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* connectivity client upgrade e2e

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants