Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change-api #832

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

change-api #832

wants to merge 1 commit into from

Conversation

ashleyvjoy
Copy link
Contributor

@ashleyvjoy ashleyvjoy commented Dec 18, 2024

Description

Setting ownerReference was failing because the GroupVersion used is incorrect "apps/v1" instead of "storage.dell.com/v1".
So when in maximal/minimal CR, when forceRemoveDriver: false, CSM installation was failing when Operator deployed from UI

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| dell/csm#1605 |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Deploy operator from UI with changes by building catalogSource and catalog image. Deployed CSM with forceRemoveDriver: false -> CSM is getting installed and pods are in running state. Tested with forceRemoveDriver: true and CSM is getting installed successfully and pods are in running state

oc get csm -A
NAMESPACE NAME CREATIONTIME CSIDRIVERTYPE CONFIGVERSION STATE
vxflexos vxflexos 20m powerflex v2.12.0 Succeeded

oc get pods -n vxflexos
NAME READY STATUS RESTARTS AGE
vxflexos-controller-686749ddb4-8f7wl 5/5 Running 2 (19m ago) 20m
vxflexos-controller-686749ddb4-lb7wz 5/5 Running 1 (19m ago) 20m
vxflexos-node-9mxw7 2/2 Running 0 20m
vxflexos-node-g2wvl 2/2 Running 0 20m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant