Powerflex secret zone validation #833
Open
+208
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivers.ExtractZones. Fixed up existing unit-tests to pass around a proper secret, rather than the "csm" value currently used, as this causes the ExtractZones() to fail on parsing during unit-testing.
key-value pair. ZoneValidation function filled in to continue correct zone validation. Unit Test code updated including infra client List code to match on labels.
…t-test bring up back to 90.0% coverage.
node labels anymore. Removing the directly associated unit test code as well. Fixing powerflex validate zone code to check that all arrays have zone detail if there is at least one array with zone detail.
anathoodell
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
gilltaran,
harishp8889,
HarishH-DELL,
JacobGros and
jooseppi-luna
as code owners
anathoodell
requested review from
karthikk92,
kumarkgosa,
bandak2,
meggm,
mgandharva,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe,
shaynafinocchiaro,
atye,
sharmilarama and
shanmydell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSM-Operator Zone Validation function is added to validate zone configuration in a cluster of nodes and powerflex secret, prior to installation (pre-checks). If the Zone validation fails, the CSM object remains in a failed state.
Validation is limited to the powerflex secret only. No node label checks are done.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Unit tests added and run to maintain coverage numbers. Basic pflex E2E scenarios run as well.
if zone validation fails - this event is logged in the csm cr.
