Makefile updates to install build tools #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- install controller-gen and kustomize tools using "go install". - remove tools.go in favor of install method above. - remove module dependency from go.mod for controller-gen and kustomize.
- compilation recipes have "build" prefix. - added "build" recipe to compile all binaries for replication. - updated readme to reflect above changes.
lukeatdell
requested review from
AronAtDell,
bharathsreekanth,
ChristianAtDell,
donatwork,
delldubey,
gallacher,
harshaatdell,
hoppea2,
santhoshatdell,
nidtara,
shanmydell and
mbasha-dell
as code owners
|
@lukeatdell There are lint errors reported. Please check. |
santhoshatdell
approved these changes
Aug 14, 2024
mbasha-dell
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Repo maintenance to update methods for installing build tools, controller-gen and kustomize as the former method is no longer supported.
toolsMakefile recipe to install controller-gen and kustomize tools using "go install".buildprefix for consistency across CSM repos.buildrecipe in Makefile to build all CSM Replication binaries and to be consistent with Makefiles across CSM repos.GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Unit tests
Binaries