Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Remove extra fields from the driver specs when using minimal sample #1594

Closed
shanmydell opened this issue Nov 15, 2024 · 3 comments
Closed
Assignees
Labels
area/csm-operator type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@shanmydell
Copy link
Collaborator

shanmydell commented Nov 15, 2024

Bug Description

Manifest file used to deploy CSM
image
Status of the Pod
image
image

Logs

image

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

Deploy the driver with the simple manifest in description

Expected Behavior

The request is to ensure no additional fields are populated in the spec unless explicitly provided by the user.

Details:

For example, consider the following YAML applied to the cluster:

apiVersion: storage.dell.com/v1
kind: ContainerStorageModule
metadata:
  name: powerflex
  namespace: powerflex
spec:
  driver:
    csiDriverType: "powerflex"
    configVersion: v2.12.0

When running kubectl get csm powerflex -n powerflex -o yaml, the resulting output includes additional fields in the spec, as shown below:

spec:
  driver:
    common:
      envs:
      - name: KUBELET_CONFIG_DIR
        value: /var/lib/kubelet
    configVersion: v2.12.0
    controller: {}
    csiDriverSpec: {}
    csiDriverType: powerflex
    initContainers:
    - envs:
      - name: MDM
        value: XXXXXXXXX
      name: sdc
    node: {}
    replicas: 2

These additional fields (e.g., common.envs, initContainers, replicas, controller, etc.) should not appear in the spec unless explicitly defined in the input YAML.

The expected behaviour is that the spec should only include the fields provided in the input YAML, such as:

spec:
  driver:
    csiDriverType: "powerflex"
    configVersion: v2.12.0

CSM Driver(s)

All drivers, tested with PowerStore and PowerFlex

Installation Type

No response

Container Storage Modules Enabled

No response

Container Orchestrator

NA

Operating System

NA

@shanmydell shanmydell added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. labels Nov 15, 2024
@shanmydell shanmydell added this to the v1.13.0 milestone Nov 15, 2024
@csmbot
Copy link
Collaborator

csmbot commented Nov 15, 2024

@shanmydell: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and respond appropriately.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

@anandrajak1 anandrajak1 removed the needs-triage Issue requires triage. label Nov 18, 2024
@anandrajak1
Copy link
Contributor

/sync

@csmbot
Copy link
Collaborator

csmbot commented Nov 18, 2024

link: 30499

@rishabhatdell rishabhatdell self-assigned this Nov 19, 2024
@rishabhatdell rishabhatdell changed the title [BUG]: Replica count is marked as zero after installing via simple manifest but two controllers are running in PowerStore [BUG]: Remove extra fields from the driver specs when using minimal sample Nov 20, 2024
@suryagupta4 suryagupta4 added area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csm-operator and removed area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csm-operator type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

5 participants