Remove Extra Fields From Minimal CR

[anathoodell]

Description

This PR removes the extra fields from the CSM CR when deploying using a minimal sample. ensuring it is cleaner, more efficient, and thoroughly validated. Below is a summary of the changes:

Key Changes

1. Replica Count Fix

   • Adjusts the replica count in the CR to align with the correct controller counts.

2. Removal of Empty Fields

   • Eliminates empty structs such as csiDriver, Node, and Controller from the CR.

3. Environment Variable Cleanup

   • Removes the KUBELET_CONFIG_DIR field from the CR.

4. PowerFlex-Specific Changes

   • Removes initContainer and sdc-monitor fields for PowerFlex in the minimal configuration.

5. PowerMax-Specific Changes

   • Removes reverseproxy env variable fields for PowerMax in the minimal configuration.

6. Improved Unit Test Coverage

   • Increases UT coverage to 97%.

7. Fix Operator Crashing

   • Fix operator crashing when initContainer ENVs are empty
   • It will use secrets to update MDM

8. E2E Test Enhancements

   • Adds an E2E test step to the minimal standalone deployment to verify:
     • A non-zero replica count.
     • Absence of unexpected fields when using the minimal sample.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1594
dell/csm#1603

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility
• I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

• Verified Minimal & Maximal Samples
• All Driver Minimal Sample E2E
• PowerScale E2E
• PowerStore E2E

[kumarp20]

When installing powermax using minimal sample, we are adding the reverseproxy module to the CR:

csm-operator/pkg/drivers/powermax.go

Line 98 in d7827cb

if !foundRevProxy {

. Shouldn't we change this to update the yamls but not update the CSM spec (like we did for SDC init container for pflex) ?

[kumarp20]

Looks like this code handles the reverse proxy scenario well. Please see if additional UTs can be added. Please ensure operator E2E passes for all platforms (in pipeline nightly jobs) to ensure this does not affect anything adversely.