Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Update CSM Authorization karavictl CLI flag descriptions #895

Closed
gashof opened this issue Jul 12, 2023 · 3 comments
Closed

[BUG]: Update CSM Authorization karavictl CLI flag descriptions #895

gashof opened this issue Jul 12, 2023 · 3 comments
Assignees
Labels
area/csm-authorization Issue pertains to the CSM Authorization module type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@gashof
Copy link

gashof commented Jul 12, 2023

Bug Description

Documentation Bug:
It looks like the --addr flag is required for karavictl storage create: at CSM 1.7:
https://dell-iac.slack.com/archives/C025E763URH/p1688961636990069
There were some changes in these area about 3 months ago
https://github.com/dell/karavi-authorization/blame/main/cmd/karavictl/cmd/storage_create.go
The documents make it look like it is optional and inherited.:
https://dell.github.io/csm-docs/docs/authorization/cli/#karavictl-storage-create
Can the document be updated for all commands that --addr is required for?
Also clarification/confirmation that this is for the proxy-server would be helpful as well in the description of -addr in each section.

Logs

Just what is in the Slack conversation, "no input provided: addr"

Screenshots

None provided

Additional Environment Information

upgrade/install CSM Authorization 1.7

Steps to Reproduce

upgrade/install CSM Authorization 1.7 then run karavictl storage create command

Expected Behavior

Based on documentation -addr flag is not required.

CSM Driver(s)

CSM Authorization 1.7

Installation Type

RPM installation

Container Storage Modules Enabled

CSM Authorization 1.7

Container Orchestrator

N/A

Operating System

N/A

@gashof gashof added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. labels Jul 12, 2023
@csmbot
Copy link
Collaborator

csmbot commented Jul 12, 2023

@gashof: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and assign an appropriate priority label.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

@shanmydell shanmydell changed the title [BUG]: [BUG]: Documentation - Authorization Jul 17, 2023
@shanmydell shanmydell added the area/csm-authorization Issue pertains to the CSM Authorization module label Jul 17, 2023
@atye atye assigned atye and unassigned sharmilarama Jul 17, 2023
@hoppea2 hoppea2 added priority/P2 and removed needs-triage Issue requires triage. labels Jul 17, 2023
@hoppea2
Copy link
Collaborator

hoppea2 commented Jul 17, 2023

/sync

@csmbot
Copy link
Collaborator

csmbot commented Jul 17, 2023

link: 16000

@atye atye closed this as completed Jul 26, 2023
@shaynafinocchiaro shaynafinocchiaro added this to the v1.8.0 milestone Jul 26, 2023
@shaynafinocchiaro shaynafinocchiaro changed the title [BUG]: Documentation - Authorization [BUG]: Update CSM Authorization karavictl CLI flag descriptions Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csm-authorization Issue pertains to the CSM Authorization module type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

7 participants