Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug-985]: Update karavictl CLI #716

Merged
merged 4 commits into from
Jul 21, 2023
Merged

[bug-985]: Update karavictl CLI #716

merged 4 commits into from
Jul 21, 2023

Conversation

atye
Copy link
Contributor

@atye atye commented Jul 19, 2023

Description

  • Removes config flag which isn't used
  • Updates examples with addr flag
  • Updates to say that admin-token and addr flag are required for relevant commands

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#895

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions
Copy link

github-actions bot commented Jul 19, 2023 •
edited
Loading

Test Results

55 tests  ±0   55 ✔️ ±0   1s ⏱️ ±0s
  3 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit de432c1. ± Comparison against base commit bcd0c4c.

♻️ This comment has been updated with latest results.

@atye atye merged commit db68de0 into main Jul 21, 2023
@atye atye deleted the bug-895-update-karavictl-cli branch July 21, 2023 14:06
@atye atye mentioned this pull request Jul 21, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@xuluna xuluna xuluna approved these changes

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@chimanjain chimanjain Awaiting requested review from chimanjain

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atye @xuluna @shaynafinocchiaro @rsedlock1958