Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions #72

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Update actions #72

merged 3 commits into from
Nov 13, 2024

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Nov 13, 2024

Description

PR to fix formatting action.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

santhoshatdell
santhoshatdell previously approved these changes Nov 13, 2024
@shaynafinocchiaro shaynafinocchiaro marked this pull request as draft November 13, 2024 15:26
@shaynafinocchiaro shaynafinocchiaro marked this pull request as ready for review November 13, 2024 15:52
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the actions.yml file and create a common-workflows file instead?

@shaynafinocchiaro
Copy link
Contributor Author

Do we want to remove the actions.yml file and create a common-workflows file instead?

@gallacher I can change the file name, but we can't use the same common-workflows template file because this repo doesn't have unit tests to run. Linting is also handled a bit differently because the repo doesn't have a go.mod file in the root directory.

@mjsdell mjsdell merged commit 3d63f3b into main Nov 13, 2024
9 checks passed
@mjsdell mjsdell deleted the update-actions branch November 13, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants