Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ro pvc feature changes #53

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Ro pvc feature changes #53

merged 4 commits into from
Aug 22, 2023

Conversation

shefali-malhotra
Copy link
Collaborator

@shefali-malhotra shefali-malhotra commented Aug 21, 2023

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#487

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

  • Updated Go version to 1.21

  • Introduced access zone in snapshot path .
    Incase of system access zone snapshot from /ifs/.snapshot directory will be refered for volume creation.
    and in case of non system access zone snapshot from /ifs/<access_zone_base_path>/.snapshot directory will be referred.
    All corresponding apis are updated.

Test performed :

  1. Created RO volume in system and non system access zone and restored them. Mounted a pod on restored volume.
  2. Created RW volume in system and non system access zone and restored them. Mounted a pod on restored volume.
Non_system_zone_without_pod System_Zone_success

Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

api/v1/api_v1.go Outdated Show resolved Hide resolved
api/v1/api_v1.go Outdated Show resolved Hide resolved
api/v1/api_v1.go Outdated Show resolved Hide resolved
api/v1/api_v1_snapshots.go Outdated Show resolved Hide resolved
snapshots.go Show resolved Hide resolved
snapshots.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants