-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ro pvc feature changes #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shefali-malhotra
requested review from
bpjain2004,
chimanjain,
nitesh3108,
prablr79,
rajkumar-palani,
Sakshi-dell,
meggm and
HarishH-DELL
as code owners
August 21, 2023 09:38
HarishH-DELL
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chimanjain
approved these changes
Aug 21, 2023
nitesh3108
reviewed
Aug 21, 2023
nitesh3108
reviewed
Aug 21, 2023
bpjain2004
reviewed
Aug 22, 2023
shefali-malhotra
force-pushed
the
ro_pvc
branch
from
August 22, 2023 09:24
466161f
to
a245398
Compare
shefali-malhotra
force-pushed
the
ro_pvc
branch
from
August 22, 2023 09:51
a245398
to
03d2063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission checklist
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
Updated Go version to 1.21
Introduced access zone in snapshot path .
Incase of system access zone snapshot from /ifs/.snapshot directory will be refered for volume creation.
and in case of non system access zone snapshot from /ifs/<access_zone_base_path>/.snapshot directory will be referred.
All corresponding apis are updated.
Test performed :