Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parsing html json #59

Merged
merged 1 commit into from
Feb 12, 2024
Merged

parsing html json #59

merged 1 commit into from
Feb 12, 2024

Conversation

nitesh3108
Copy link
Collaborator

PR Submission checklist

Logic twist to handle UTs

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1134

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

HarishH-DELL
HarishH-DELL approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nitesh3108 nitesh3108 merged commit d72da85 into main Feb 12, 2024
1 check failed
@anandrajak1 anandrajak1 deleted the handle-html-json-enhancements branch October 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@panigs7 panigs7 panigs7 approved these changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitesh3108 @panigs7 @HarishH-DELL