Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/Delete Metro Volume Group #134

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Conversation

lukeatdell
Copy link
Contributor

Description

Adding support for volume_group endpoint actions, configure_metro and end_metro to configure and end metro replication for volume groups.

  • Updated go modules.
  • Updated mocks.
  • Added unit and integration tests for configure_metro and end_metro.
  • Improved metrics integration tests to avoid nil pointer dereference.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1443

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you maintained backward compatibility

Testing

Integration Testing

+1.6%
image

Unit Testing

+0.1%
image
+0.0%
image

santhoshatdell
santhoshatdell previously approved these changes Sep 23, 2024
volume_group.go Outdated Show resolved Hide resolved
volume_types.go Outdated Show resolved Hide resolved
inttests/volume_group_test.go Show resolved Hide resolved
@lukeatdell lukeatdell merged commit 1c719e6 into main Sep 24, 2024
4 checks passed
@lukeatdell lukeatdell deleted the usr/lukeatdell/metro-vol-group branch September 24, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants