Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new methods for NAS server support #51

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Added new methods for NAS server support #51

merged 2 commits into from
Apr 18, 2023

Conversation

ashleyvjoy
Copy link
Contributor

@ashleyvjoy ashleyvjoy commented Apr 17, 2023

Description

Added 4 new methods - GetNASByName, GetNAS, CreateNAS, DeleteNAS and UTs

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| dell/csm#763 |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested creation of NAS server on PowerFlex 4.0 array, retrieving NAS server by name and id and deleting NAS server.

nas-test6

=== RUN   TestGetNasByName
=== RUN   TestGetNasByName/success
--- PASS: TestGetNasByName/success (0.00s)
=== RUN   TestGetNasByName/not_found
--- PASS: TestGetNasByName/not_found (0.00s)
--- PASS: TestGetNasByName (0.00s)
=== RUN   TestGetNAS
=== RUN   TestGetNAS/success
--- PASS: TestGetNAS/success (0.00s)
=== RUN   TestGetNAS/not_found
--- PASS: TestGetNAS/not_found (0.00s)
--- PASS: TestGetNAS (0.00s)
=== RUN   TestCreateNAS
=== RUN   TestCreateNAS/bad_request
--- PASS: TestCreateNAS/bad_request (0.00s)
=== RUN   TestCreateNAS/success
--- PASS: TestCreateNAS/success (0.00s)
--- PASS: TestCreateNAS (0.00s)
=== RUN   Test_DeleteNAS
--- PASS: Test_DeleteNAS (0.00s)
PASS
ok      github.com/dell/goscaleio       0.011s

nasinttestspass-2

Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashleyvjoy rebase your branch with main. Some of the changes are already in main. rename the files fs.go and fs_test.go to nfs.go and nfs_test.go

Copy link
Contributor

@khareRajshree khareRajshree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the integration tests for the same as well.

nfs_test.go Outdated Show resolved Hide resolved
@ashleyvjoy
Copy link
Contributor Author

Please add the integration tests for the same as well.

Added the integration tests

inttests/nfs_int_test.go Outdated Show resolved Hide resolved
@ashleyvjoy
Copy link
Contributor Author

@ashleyvjoy rebase your branch with main. Some of the changes are already in main. rename the files fs.go and fs_test.go to nfs.go and nfs_test.go

Done

@ashleyvjoy ashleyvjoy requested a review from VamsiSiddu-7 April 18, 2023 09:21
@ashleyvjoy ashleyvjoy merged commit aa6febd into main Apr 18, 2023
@shanmydell shanmydell deleted the nas-server-poc branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants